Re: [PATCH V1 02/10] arch/xtensa: Move kmap build bug out of the way

[Christoph Hellwig]

On Thu, Apr 30, 2020 at 01:38:37PM -0700, ira.weiny@xxxxxxxxx wrote:
> @@ -88,6 +88,11 @@ void __init kmap_init(void)
>  {
>  	unsigned long kmap_vstart;
>  
> +	/* Check if this memory layout is broken because PKMAP overlaps
> +	 * page table.
> +	 */
> +	BUILD_BUG_ON(PKMAP_BASE <
> +		     TLBTEMP_BASE_1 + TLBTEMP_SIZE);

This can fit on a single line.  Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>