Re: [PATCH V1 04/10] arch/kunmap: Remove duplicate kunmap implementations

[Christoph Hellwig]

On Thu, Apr 30, 2020 at 01:38:39PM -0700, ira.weiny@xxxxxxxxx wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
> 
> All architectures do exactly the same thing for kunmap(); remove all the
> duplicate definitions and lift the call to the core.
> 
> This also has the benefit of changing kmap_unmap() on a number of
> architectures to be an inline call rather than an actual function.
> 
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>