Re: [PATCH V1 05/10] arch/kmap_atomic: Consolidate duplicate code

[Christoph Hellwig]

On Thu, Apr 30, 2020 at 01:38:40PM -0700, ira.weiny@xxxxxxxxx wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
> 
> Every arch has the same code to ensure atomic operations and a check for
> !HIGHMEM page.
> 
> Remove the duplicate code by defining a core kmap_atomic() which only
> calls the arch specific kmap_atomic_high() when the page is high memory.
> 
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>