Re: [PATCH net-next 4/4] net: phy: bcm54140: add cable diagnostics support

[kbuild test robot]

Hi Michael,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on next-20200508]
[cannot apply to net/master linus/master v5.7-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Michael-Walle/net-phy-broadcom-cable-tester-support/20200510-063955
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 2c674bec76d35b75c7c730f863424387c9e9633a
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/net/phy/bcm54140.c:834:13: error: 'PHY_POLL_CABLE_TEST' undeclared here (not in a function)
     834 |   .flags  = PHY_POLL_CABLE_TEST,
         |             ^~~~~~~~~~~~~~~~~~~
   drivers/net/phy/bcm54140.c:846:4: error: 'struct phy_driver' has no member named 'cable_test_start'
     846 |   .cable_test_start = bcm_phy_cable_test_start_rdb,
         |    ^~~~~~~~~~~~~~~~
>> drivers/net/phy/bcm54140.c:846:23: error: initialization of 'int (*)(struct phy_device *, bool)' {aka 'int (*)(struct phy_device *, _Bool)'} from incompatible pointer type 'int (*)(struct phy_device *)' [-Werror=incompatible-pointer-types]
     846 |   .cable_test_start = bcm_phy_cable_test_start_rdb,
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/phy/bcm54140.c:846:23: note: (near initialization for 'bcm54140_drivers[0].set_loopback')
   drivers/net/phy/bcm54140.c:847:4: error: 'struct phy_driver' has no member named 'cable_test_get_status'
     847 |   .cable_test_get_status = bcm_phy_cable_test_get_status_rdb,
         |    ^~~~~~~~~~~~~~~~~~~~~
   drivers/net/phy/bcm54140.c:847:28: warning: excess elements in struct initializer
     847 |   .cable_test_get_status = bcm_phy_cable_test_get_status_rdb,
         |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/phy/bcm54140.c:847:28: note: (near initialization for 'bcm54140_drivers[0]')
   cc1: some warnings being treated as errors

vim +846 drivers/net/phy/bcm54140.c

   828	
   829	static struct phy_driver bcm54140_drivers[] = {
   830		{
   831			.phy_id         = PHY_ID_BCM54140,
   832			.phy_id_mask    = BCM54140_PHY_ID_MASK,
   833			.name           = "Broadcom BCM54140",
   834			.flags		= PHY_POLL_CABLE_TEST,
   835			.features       = PHY_GBIT_FEATURES,
   836			.config_init    = bcm54140_config_init,
   837			.did_interrupt	= bcm54140_did_interrupt,
   838			.ack_interrupt  = bcm54140_ack_intr,
   839			.config_intr    = bcm54140_config_intr,
   840			.probe		= bcm54140_probe,
   841			.suspend	= genphy_suspend,
   842			.resume		= genphy_resume,
   843			.soft_reset	= genphy_soft_reset,
   844			.get_tunable	= bcm54140_get_tunable,
   845			.set_tunable	= bcm54140_set_tunable,
 > 846			.cable_test_start = bcm_phy_cable_test_start_rdb,
   847			.cable_test_get_status = bcm_phy_cable_test_get_status_rdb,
   848		},
   849	};
   850	module_phy_driver(bcm54140_drivers);
   851	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip