Re: [PATCH][next] sfc: fix dereference of table before it is null checked

From: David Miller
Date: Wed May 13 2020 - 18:20:31 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Tue, 12 May 2020 18:13:55 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently pointer table is being dereferenced on a null check of
> table->must_restore_filters before it is being null checked, leading
> to a potential null pointer dereference issue. Fix this by null
> checking table before dereferencing it when checking for a null
> table->must_restore_filters.
>
> Addresses-Coverity: ("Dereference before null check")
> Fixes: e4fe938cff04 ("sfc: move 'must restore' flags out of ef10-specific nic_data")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied, thanks.