Re: [PATCH v3 3/4] MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO

From: Maciej W. Rozycki
Date: Wed May 13 2020 - 18:38:01 EST


On Sun, 26 Apr 2020, Nathan Chancellor wrote:

> > this causes build errors for me when (cross) compiling a big endian target:
> >
> > target is little endian
> > mips64-linux-gnu-ld: arch/mips/vdso/elf.o: endianness incompatible with that of the selected emulation
> > mips64-linux-gnu-ld: failed to merge target specific data of file arch/mips/vdso/elf.o
>
> Thanks for the report. I will look into it tomorrow and hopefully have a
> v4 by then.

Can you actually record in the change description what the difference in
the relevant link command is, as shown where `V=1' has been used with
`make' invocation?

Actually running `diff -bu' on the whole `V=1' build log obtained without
and with your proposed change applied and ensuring there are no unwanted
changes elsewhere will be a good measure of the correctness of your patch.
You may have to prepare to be patient and run with `-j1' to make sure any
`make' parallelism does not interfere with the order of commands printed.

Maciej