Re: [PATCH v5] MIPS: Truncate link address into 32bit for 32bit kernel

From: Maciej W. Rozycki
Date: Wed May 13 2020 - 18:38:48 EST


On Thu, 23 Apr 2020, Jiaxun Yang wrote:

> > Alternatively, have you made any attempt to verify if actually replacing
> >the setting for VMLINUX_LOAD_ADDRESS would be safe? Glancing over its use
> >there do not appear to be many places.
>
> Limited experiments showed it should be fine...
>
> But MIPS kernel has some design I'm not really familiar with like SYM32 for
> 64-bit kernel and special address space design for Trap-and-emul KVM.

This only affects CONFIG_32BIT kernels, so SYM32 does not apply; I can't
comment on KVM. There's still that bunch of:

$(shell expr $(...) \< 0xffffffff80000000)

constructs I mentioned before, so let's leave your change as it stands at
this time. Please do rename the variable as I suggested though, I hope
that's not a big deal.

Maciej