Re: [PATCH 04/10] riscv: Fix print_vm_layout build error if NOMMU
From: Kefeng Wang
Date: Thu May 14 2020 - 07:43:04 EST
On 2020/5/14 18:10, Alex Ghiti wrote:
Hi,
On 5/10/20 10:19 PM, Kefeng Wang wrote:
arch/riscv/mm/init.c: In function âprint_vm_layoutâ:
arch/riscv/mm/init.c:68:37: error: âFIXADDR_STARTâ undeclared (first
use in this function);
arch/riscv/mm/init.c:69:20: error: âFIXADDR_TOPâ undeclared
arch/riscv/mm/init.c:70:37: error: âPCI_IO_STARTâ undeclared
arch/riscv/mm/init.c:71:20: error: âPCI_IO_ENDâ undeclared
arch/riscv/mm/init.c:72:38: error: âVMEMMAP_STARTâ undeclared
arch/riscv/mm/init.c:73:20: error: âVMEMMAP_ENDâ undeclared (first
use in this function);
Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
---
 arch/riscv/mm/init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
index dfcaebc3928f..58c39c44b9c9 100644
--- a/arch/riscv/mm/init.c
+++ b/arch/riscv/mm/init.c
@@ -49,7 +49,7 @@ static void setup_zero_page(void)
ÂÂÂÂÂ memset((void *)empty_zero_page, 0, PAGE_SIZE);
 }
 -#ifdef CONFIG_DEBUG_VM
+#if defined(CONFIG_MMU) && defined(DEBUG_VM)
Shouldn't it be CONFIG_DEBUG_VM ?
oops, should be CONFIG_DEBUG_VM, will send v2, thanks.
 static inline void print_mlk(char *name, unsigned long b, unsigned
long t)
 {
ÂÂÂÂÂ pr_notice("%12s : 0x%08lx - 0x%08lxÂÂ (%4ld kB)\n", name, b, t,
Alex
.