Re: [PATCH] MIPS: update tlb even if pte entry has no change

From: maobibo
Date: Thu May 14 2020 - 07:42:10 EST




On 05/14/2020 05:37 PM, Sergei Shtylyov wrote:
> On 14.05.2020 12:35, Sergei Shtylyov wrote:
>
>>> From: bibo mao <maobibo@xxxxxxxxxxx>
>>>
>>> If there are two threads reading the same memory and tlb miss happens,
>>> one thread fills pte entry, the other reads new pte value during page fault
>>> handling. PTE value may be updated before page faul, so the process need
>>
>> Fault.
>
> And "needs".
>
>>> need update tlb still.
>
> Oh, and one "need" is enough. :-)

Thank for reviewing my patch, will fix this typo issue in next version.

Best Regards
bibo, mao

>
>>> Also this patch define flush_tlb_fix_spurious_fault as empty, since it not
>>> necessary to flush the page for all CPUs
>>>
>>> Signed-off-by: Bibo Mao <maobibo@xxxxxxxxxxx>
>> [...]
>
> MBR, Sergei