Re: [PATCH] MIPS: update tlb even if pte entry has no change

From: Maciej W. Rozycki
Date: Thu May 14 2020 - 09:34:35 EST


On Thu, 14 May 2020, Sergei Shtylyov wrote:

> >> If there are two threads reading the same memory and tlb miss happens,
> >> one thread fills pte entry, the other reads new pte value during page fault
> >> handling. PTE value may be updated before page faul, so the process need
> >
> > ÂÂ Fault.
>
> And "needs".
>
> >> need update tlb still.
>
> Oh, and one "need" is enough. :-)

Hmm, "the process need update" looks right to me (compare "the process
need not update") as "need" is used as a modal verb in this sentence.
Alternatively "the process needs to update" could be used (with "need" as
a main verb, and "to" then).

I'm not a native English speaker though, so I might be missing a usage
subtlety here.

NB I'd be in favour of capitalising "PTE" and "TLB" consistently
throughout though as the norm is with acronyms.

Maciej