Re: [PATCH v2 2/3] ASoC: tlv320adcx140: Add device tree property for PDM edges

[Dan Murphy]

Richard

On 5/14/20 3:09 AM, Ricard Wanderlof wrote:
> On Wed, 13 May 2020, Dan Murphy wrote:
>
> > Add a device tree property to configure the PDM sampling edge for each
> > digital microphone.
> >
> > CC: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > ---
> >  Â.../devicetree/bindings/sound/tlv320adcx140.yamlÂÂ | 14 ++++++++++++++
> >  Â1 file changed, 14 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml
> > b/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml
> > index ab2268c0ee67..55668c7d261d 100644
> > --- a/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml
> > +++ b/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml
> > @@ -63,6 +63,19 @@ properties:
> >  ÂÂÂÂÂÂ - $ref: /schemas/types.yaml#/definitions/uint32
> >  ÂÂÂÂÂÂ - enum: [0, 1, 2]
> >   
> > +Â ti,pdm-edge-select:
> > +ÂÂÂ description: |
> > + Defines the sampling edge configuration for the PDM inputs. This is
> > an
> > +ÂÂÂÂÂÂ array defined as <PDMIN1 PDMIN2 PDMIN3 PDMIN4>. 0 (default) is
> > negative
> > +ÂÂÂÂÂÂ sampling edge and 1 is positive sampling edge.
> A bit of a nitpick, but I would think of the edges as
> negative-going/positive-going, or rising/falling. Not sure if anyone would
> misunderstand 'negative edge' in practice though.

I will re-write the description to be more descriptive.

> > +ÂÂÂ allOf:
> > +ÂÂÂÂÂ - $ref: /schemas/types.yaml#/definitions/uint32-array
> > +ÂÂÂÂÂ - minItems: 1
> > +ÂÂÂÂÂÂÂ maxItems: 4
> > +ÂÂÂÂÂÂÂ items:
> > +ÂÂÂÂÂÂÂÂÂ maximum: 1
> > +ÂÂÂÂÂÂÂ default: [0, 0, 0, 0]
> > +
> >  Ârequired:
> >  ÂÂ - compatible
> >  ÂÂ - reg
> > @@ -77,6 +90,7 @@ examples:
> >  ÂÂÂÂÂÂÂÂ compatible = "ti,tlv320adc5140";
> >  ÂÂÂÂÂÂÂÂ reg = <0x4c>;
> >  ÂÂÂÂÂÂÂÂ ti,mic-bias-source = <6>;
> > +ÂÂÂÂÂÂÂ ti,pdm-edge-select = < 0 1 0 1>;
> Should there really be a space between < and 0 ?

I will remove the space

Dan

> /Ricard