Re: [PATCH v2 2/2] MIPS: Fix build errors under CONFIG_HAVE_STD_PC_SERIAL_PORT

[Tiezhu Yang]

On 05/15/2020 04:19 PM, Jiaxun Yang wrote:
> ä 2020å5æ15æ GMT+08:00 äå3:54:46, Tiezhu Yang <yangtiezhu@xxxxxxxxxxx> åå:
> > On 05/15/2020 03:39 PM, Thomas Bogendoerfer wrote:
> > > On Fri, May 15, 2020 at 11:23:05AM +0800, Tiezhu Yang wrote:
> > > > When CONFIG_HAVE_STD_PC_SERIAL_PORT is set, include linux/module.h to fix
> > > > the following build errors:
> > > how are you doing this ? To me it looks like this CONFIG option isn't
> > > used anymore.
> > Because I will use arch/mips/kernel/8250-platform.c in the near future,
> > so make MACH_LOONGSON64 selects HAVE_STD_PC_SERIAL_PORT, then
> > I find the build errors.
> Please never use it.
> If you are willing to add serial port then please do it
> in devicetree.
> Platform devices in wild is dangerous and it will break everything.

Hi Jiaxun,

OK, Thanks for your suggestion. I will rethink my plan.

Hi Thomas,

Because CONFIG_HAVE_STD_PC_SERIAL_PORT is not used anymore,
(1) Is it necessary to fix this possible build error?
or
(2) Should we remove this arch/mips/kernel/8250-platform.c?

Thanks,
Tiezhu Yang

> > Thanks,
> > Tiezhu Yang
> >
> > > Thomas.