Re: [PATCH 1/4] hung_task: Move hung_task sysctl interface to hung_task_sysctl.c

[Xiaoming Ni]

On 2020/5/15 16:04, Kees Cook wrote:
> On Fri, May 15, 2020 at 12:33:41PM +0800, Xiaoming Ni wrote:
> > Move hung_task sysctl interface to hung_task_sysctl.c.
> > Use register_sysctl() to register the sysctl interface to avoid
> > merge conflicts when different features modify sysctl.c at the same time.
> >
> > Signed-off-by: Xiaoming Ni <nixiaoming@xxxxxxxxxx>
> > ---
> >   include/linux/sched/sysctl.h |  8 +----
> >   kernel/Makefile              |  4 ++-
> >   kernel/hung_task.c           |  6 ++--
> >   kernel/hung_task.h           | 21 ++++++++++++
> >   kernel/hung_task_sysctl.c    | 80 ++++++++++++++++++++++++++++++++++++++++++++
>
> Why a separate file? That ends up needing changes to Makefile, the
> creation of a new header file, etc. Why not just put it all into
> hung_task.c directly?
>
> -Kees
But Luis Chamberlain's suggestion is to put the hung_task sysctl code in 
a separate file. Details are in https://lkml.org/lkml/2020/5/13/762.
I am a little confused, not sure which way is better.

Thanks
Xiaoming Ni