Re: [RFC PATCH 02/13] scsi: ufshpb: Init part I - Read HPB config

From: Randy Dunlap
Date: Fri May 15 2020 - 11:33:30 EST


Hi--

On 5/15/20 3:30 AM, Avri Altman wrote:
> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
> index e2005ae..a540919 100644
> --- a/drivers/scsi/ufs/Kconfig
> +++ b/drivers/scsi/ufs/Kconfig
> @@ -160,3 +160,15 @@ config SCSI_UFS_BSG
>
> Select this if you need a bsg device node for your UFS controller.
> If unsure, say N.
> +
> +config SCSI_UFS_HPB
> + bool "Support UFS Host Performance Booster (HPB)"
> + depends on SCSI_UFSHCD
> + help
> + A UFS feature targeted to improve random read performance. It uses
> + the hostâs system memory as a cache for L2P map data, so that both
> + physical block address (PBA) and logical block address (LBA) can be
> + delivered in HPB read command.
> +
> + Select this to enable this feature.
> + If unsure, say N.

Please follow Documentation/process/coding-style.rst for Kconfig files:

Lines under a ``config`` definition are indented with
one tab, while help text is indented an additional two spaces.

I.e., not a mixture.

thanks.
--
~Randy