Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

From: Sergei Shtylyov
Date: Mon May 18 2020 - 09:18:01 EST


Hello!

On 18.05.2020 15:27, Lad, Prabhakar wrote:

Add a device node for the Watchdog Timer (RWDT) controller on the Renesas
RZ/G1H (r8a7742) SoC.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@xxxxxxxxxxxxxx>

Thanks for your patch!

--- a/arch/arm/boot/dts/r8a7742.dtsi
+++ b/arch/arm/boot/dts/r8a7742.dtsi
@@ -201,6 +201,16 @@
#size-cells = <2>;
ranges;

+ rwdt: watchdog@e6020000 {
+ compatible = "renesas,r8a7742-wdt",
+ "renesas,rcar-gen2-wdt";
+ reg = <0 0xe6020000 0 0x0c>;
+ clocks = <&cpg CPG_MOD 402>;
+ power-domains = <&sysc R8A7742_PD_ALWAYS_ON>;
+ resets = <&cpg 402>;
+ status = "disabled";

Missing "interrupts" property.

"interrupts" property isn't used by rwdt driver and can be dropped
from bindings file.

DT describes the hardware, not its driver's abilities.

Cheers,
--Prabhakar

MBR, Sergei