Re: [PATCH 22/24] uaccess: add memzero_user
From: Al Viro
Date: Wed May 20 2020 - 16:50:57 EST
On Wed, May 20, 2020 at 01:40:36PM -0700, Christoph Hellwig wrote:
> On Wed, May 20, 2020 at 01:21:43PM -0400, Paolo Bonzini wrote:
> > + unsafe_put_user(val, (unsigned long __user *) from, err_fault);
>
> This adds a way too long line. In many ways it would be much nicer if
> you used an unsigned long __user * variable internally, a that would
> remove all these crazy casts and actually make the code readable.
Er... what's wrong with clear_user(), anyway?