Re: [PATCH 22/24] uaccess: add memzero_user

From: Paolo Bonzini
Date: Wed May 20 2020 - 17:13:43 EST


On 20/05/20 22:40, Christoph Hellwig wrote:
> On Wed, May 20, 2020 at 01:21:43PM -0400, Paolo Bonzini wrote:
>> + unsafe_put_user(val, (unsigned long __user *) from, err_fault);
> This adds a way too long line. In many ways it would be much nicer if
> you used an unsigned long __user * variable internally, a that would
> remove all these crazy casts and actually make the code readable.
>

Good idea, thanks.

Paolo