Re: [PATCH v10 1/2] dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC

[Ramuthevar, Vadivel MuruganX]

Hi Rob,

On 30/5/2020 3:31 am, Rob Herring wrote:
> On Thu, May 28, 2020 at 11:39:28PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> > From: Ramuthevar Vadivel Murugan<vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx>
> >
> > Add YAML file for dt-bindings to support NAND Flash Controller
> > on Intel's Lightning Mountain SoC.
> >
> > Signed-off-by: Ramuthevar Vadivel Murugan<vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/mtd/intel,lgm-nand.yaml    | 93 ++++++++++++++++++++++
> >   1 file changed, 93 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml
> > new file mode 100644
> > index 000000000000..afecc9920e04
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml
> > @@ -0,0 +1,93 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:http://devicetree.org/schemas/mtd/intel,lgm-nand.yaml#
> > +$schema:http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Intel LGM SoC NAND Controller Device Tree Bindings
> > +
> > +allOf:
> > +  - $ref: "nand-controller.yaml"
> > +
> > +maintainers:
> > +  - Ramuthevar Vadivel Murugan<vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    const: intel,lgm-nand-controller
> Doesn't match the example.
Thank you for the review comments...

if we add the compatible = intel,lgm-nand-controller it throws an error 
like below..

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/intel,lgm-nand.example.dt.yaml: 
nand-controller@e0f00000: '#address-cells', '#size-cells' do not match 
any of the regexes: '^nand@[a-f0-9]+$', 'pinctrl-[0-9]+'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/intel,lgm-nand.example.dt.yaml: 
nand-controller@e0f00000: nand@0: '#address-cells', '#size-cells', 
'nand-on-flash-bbt' do not match any of the regexes: 'pinctrl-[0-9]+'

referred from this file 
:Documentation/devicetree/bindings/mtd/nand-controller.yaml

fixed the compatible and example doesn't match issue.

Regards
Vadivel

>