Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

From: David Miller
Date: Fri May 29 2020 - 20:18:43 EST

Next message: Leo Yan: "Re: [PATCH v7 0/3] perf arm-spe: Add support for synthetic events"
Previous message: Ramuthevar, Vadivel MuruganX: "Re: [PATCH v10 1/2] dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC"
In reply to: Vadym Kochan: "[net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices"
Next in thread: Vadym Kochan: "Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Please remove all of the __packed attributes.

I looked at your data structures and all of them use fixed sized types
and are multiples of 4 so the __packed attribute is completely
unnecessary.

The alignment attribute is also unnecessary so please remove that too.

Next message: Leo Yan: "Re: [PATCH v7 0/3] perf arm-spe: Add support for synthetic events"
Previous message: Ramuthevar, Vadivel MuruganX: "Re: [PATCH v10 1/2] dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC"
In reply to: Vadym Kochan: "[net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices"
Next in thread: Vadym Kochan: "Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]