Re: [PATCH] afs: Fix memory leak in afs_put_sysnames()

From: David Howells
Date: Mon Jun 01 2020 - 08:35:12 EST


Markus Elfring <Markus.Elfring@xxxxxx> wrote:

> > sysnames should be freed after refcnt being decreased to zero in
> > afs_put_sysnames().
>
> * I suggest to use the wording âreference counterâ.

Can you use ASCII quotes please? Not all fonts contain these quotes, and
occasionally they got copied into commit messages.

> * Where did you notice a âmemory leakâ here?

He said "sysnames should be freed after refcnt being decreased to zero in
afs_put_sysnames()".

> * Will the tag âFixesâ become relevant for the commit message?

It is the correct tag.

David