Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

From: Dan Carpenter
Date: Tue Jun 02 2020 - 11:39:23 EST

On Tue, Jun 02, 2020 at 01:10:34PM +0200, Markus Elfring wrote:
> > The original patch was basically fine.
> I propose to reconsider the interpretation of the software situation once more.
> * Should the allocated clock object be kept usable even after
> a successful return from this function?

Heh. You're right. The patch is freeing "clk" on the success path so
that doesn't work.

dan carpenter