Re: Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()
From: dinghao . liu
Date: Tue Jun 02 2020 - 22:22:09 EST
> On Tue, Jun 02, 2020 at 01:10:34PM +0200, Markus Elfring wrote:
> > > The original patch was basically fine.
> > I propose to reconsider the interpretation of the software situation once more.
> > * Should the allocated clock object be kept usable even after
> > a successful return from this function?
> Heh. You're right. The patch is freeing "clk" on the success path so
> that doesn't work.
Ben has explained this problem:
Since the caller will check "pclk" on failure, we don't need to free
"clk" in gm20b_clk_new() and I think this patch is no longer needed.