Re: [PATCH v2 net-next 05/10] net: mscc: ocelot: VCAP IS1 support

[Jakub Kicinski]

On Tue,  2 Jun 2020 13:18:23 +0800 Xiaoliang Yang wrote:
> VCAP IS1 is a VCAP module which can filter MAC, IP, VLAN, protocol, and
> TCP/UDP ports keys, and do Qos classified and VLAN retag actions.
> 
> This patch added VCAP IS1 support in ocelot ace driver, which can supports
> vlan modify and skbedit priority action of tc filter.
> Usage:
> 	tc qdisc add dev swp0 ingress
> 	tc filter add dev swp0 protocol 802.1Q parent ffff: flower \
> 	skip_sw vlan_id 1 vlan_prio 1 action vlan modify id 2 priority 2
> 
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@xxxxxxx>

drivers/net/dsa/ocelot/felix_vsc9959.c:570:19: warning: symbol 'vsc9959_vcap_is1_keys' was not declared. Should it be static?
drivers/net/dsa/ocelot/felix_vsc9959.c:621:19: warning: symbol 'vsc9959_vcap_is1_actions' was not declared. Should it be static?
drivers/net/ethernet/mscc/ocelot_ace.c: In function ÃâËis1_entry_setÃââ:
drivers/net/ethernet/mscc/ocelot_ace.c:733:27: warning: variable ÃâËip_dataÃââ set but not used [-Wunused-but-set-variable]
 733 |   struct ocelot_vcap_u48 *ip_data;
     |                           ^~~~~~~
drivers/net/ethernet/mscc/ocelot_ace.c:732:32: warning: variable ÃâËdsÃââ set but not used [-Wunused-but-set-variable]
 732 |   struct ocelot_vcap_u8 proto, ds;
     |                                ^~
drivers/net/ethernet/mscc/ocelot_ace.c:727:51: warning: variable ÃâËtcp_pshÃââ set but not used [-Wunused-but-set-variable]
 727 |   enum ocelot_vcap_bit tcp_fin, tcp_syn, tcp_rst, tcp_psh;
     |                                                   ^~~~~~~
drivers/net/ethernet/mscc/ocelot_ace.c:727:42: warning: variable ÃâËtcp_rstÃââ set but not used [-Wunused-but-set-variable]
 727 |   enum ocelot_vcap_bit tcp_fin, tcp_syn, tcp_rst, tcp_psh;
     |                                          ^~~~~~~
drivers/net/ethernet/mscc/ocelot_ace.c:727:33: warning: variable ÃâËtcp_synÃââ set but not used [-Wunused-but-set-variable]
 727 |   enum ocelot_vcap_bit tcp_fin, tcp_syn, tcp_rst, tcp_psh;
     |                                 ^~~~~~~
drivers/net/ethernet/mscc/ocelot_ace.c:727:24: warning: variable ÃâËtcp_finÃââ set but not used [-Wunused-but-set-variable]
 727 |   enum ocelot_vcap_bit tcp_fin, tcp_syn, tcp_rst, tcp_psh;
     |                        ^~~~~~~
drivers/net/ethernet/mscc/ocelot_ace.c:726:33: warning: variable ÃâËtcp_urgÃââ set but not used [-Wunused-but-set-variable]
 726 |   enum ocelot_vcap_bit tcp_ack, tcp_urg;
     |                                 ^~~~~~~
drivers/net/ethernet/mscc/ocelot_ace.c:726:24: warning: variable ÃâËtcp_ackÃââ set but not used [-Wunused-but-set-variable]
 726 |   enum ocelot_vcap_bit tcp_ack, tcp_urg;
     |                        ^~~~~~~
drivers/net/ethernet/mscc/ocelot_ace.c:725:24: warning: variable ÃâËttlÃââ set but not used [-Wunused-but-set-variable]
 725 |   enum ocelot_vcap_bit ttl, fragment, options;
     |                        ^~~
drivers/net/ethernet/mscc/ocelot_ace.c:724:24: warning: variable ÃâËseq_zeroÃââ set but not used [-Wunused-but-set-variable]
 724 |   enum ocelot_vcap_bit seq_zero, tcp;
     |                        ^~~~~~~~
drivers/net/ethernet/mscc/ocelot_ace.c:723:36: warning: variable ÃâËsport_eq_dportÃââ set but not used [-Wunused-but-set-variable]
 723 |   enum ocelot_vcap_bit sip_eq_dip, sport_eq_dport;
     |                                    ^~~~~~~~~~~~~~
drivers/net/ethernet/mscc/ocelot_ace.c:723:24: warning: variable ÃâËsip_eq_dipÃââ set but not used [-Wunused-but-set-variable]
 723 |   enum ocelot_vcap_bit sip_eq_dip, sport_eq_dport;
     |                        ^~~~~~~~~~