Re: [PATCH v2 net-next 06/10] net: mscc: ocelot: VCAP ES0 support

[Jakub Kicinski]

On Tue,  2 Jun 2020 13:18:24 +0800 Xiaoliang Yang wrote:
> VCAP ES0 is an egress VCAP working on all outgoing frames.
> This patch added ES0 driver to support vlan push action of tc filter.
> Usage:
> 	tc filter add dev swp1 egress protocol 802.1Q flower skip_sw
> 	vlan_id 1 vlan_prio 1 action vlan push id 2 priority 2
> 
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@xxxxxxx>

Please make sure code builds cleanly with W=1 C=1 flags.

drivers/net/dsa/ocelot/felix_vsc9959.c:577:19: warning: symbol 'vsc9959_vcap_es0_keys' was not declared. Should it be static?
drivers/net/dsa/ocelot/felix_vsc9959.c:588:19: warning: symbol 'vsc9959_vcap_es0_actions' was not declared. Should it be static?