Re: [PATCH] dmaengine: stm32-mdma: call pm_runtime_put if pm_runtime_get_sync fails
From: Geert Uytterhoeven
Date: Wed Jun 03 2020 - 18:01:34 EST
Thanks for your comment!
On Wed, Jun 3, 2020 at 8:53 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
> > Calling pm_runtime_get_sync increments the counter even in case of
> > failure, causing incorrect ref count. Call pm_runtime_put if
> > pm_runtime_get_sync fails.
> Is it appropriate to copy a sentence from the change description
> into the patch subject?
> How do you think about a wording variant like the following?
> The PM runtime reference counter is generally incremented by a call of
> the function âpm_runtime_get_syncâ.
> Thus call the function âpm_runtime_putâ also in two error cases
> to keep the reference counting consistent.
IMHO the important part is "even in case of failure", which you dropped.
Missing that point was the root cause of the issue being fixed.
Hence I prefer the original description, FWIW.
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds