Re: dmaengine: stm32-mdma: call pm_runtime_put if pm_runtime_get_sync fails

From: Markus Elfring
Date: Thu Jun 04 2020 - 01:44:08 EST

>>> Calling pm_runtime_get_sync increments the counter even in case of
>>> failure, causing incorrect ref count. Call pm_runtime_put if
>>> pm_runtime_get_sync fails.
>> Is it appropriate to copy a sentence from the change description
>> into the patch subject?
>> How do you think about a wording variant like the following?
>> The PM runtime reference counter is generally incremented by a call of
>> the function âpm_runtime_get_syncâ.
>> Thus call the function âpm_runtime_putâ also in two error cases
>> to keep the reference counting consistent.
> IMHO the important part is "even in case of failure", which you dropped.
> Missing that point was the root cause of the issue being fixed.
> Hence I prefer the original description, FWIW.

Would you like to comment any more of the presented patch review concerns?

Can it make sense to combine any adjustments into a single patch
according to the discussed software transformation pattern?*&q=engine%3A+stm32&archive=both