Re: [PATCH 4/5] Huawei BMA: Adding Huawei BMA driver: cdev_veth_drv

From: Randy Dunlap
Date: Mon Jun 22 2020 - 12:43:22 EST


On 6/22/20 9:03 AM, yunaixin03610@xxxxxxx wrote:
> diff --git a/drivers/net/ethernet/huawei/bma/Makefile b/drivers/net/ethernet/huawei/bma/Makefile
> index e6e46d820082..c626618f47fb 100644
> --- a/drivers/net/ethernet/huawei/bma/Makefile
> +++ b/drivers/net/ethernet/huawei/bma/Makefile
> @@ -5,3 +5,4 @@
> obj-$(CONFIG_BMA) += edma_drv/
> obj-$(CONFIG_BMA) += cdev_drv/
> obj-$(CONFIG_BMA) += veth_drv/
> +obj-$(CONFIG_BMA) += cdev_veth_drv/
> \ No newline at end of file

Please fix the "No newline" warning.

> diff --git a/drivers/net/ethernet/huawei/bma/cdev_veth_drv/Kconfig b/drivers/net/ethernet/huawei/bma/cdev_veth_drv/Kconfig
> new file mode 100644
> index 000000000000..97829c5487c2
> --- /dev/null
> +++ b/drivers/net/ethernet/huawei/bma/cdev_veth_drv/Kconfig
> @@ -0,0 +1,11 @@
> +#
> +# Huawei BMA software driver configuration
> +#
> +
> +config BMA
> + tristate "Huawei BMA Software Communication Driver"
> +
> + ---help---

Juse use
help

> + This driver supports Huawei BMA Software. It is used
> + to communication between Huawei BMA and BMC software.
> +


--
~Randy
Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>