Re: [PATCH v3] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

[Fabio Estevam]

Hi Sven,

On Wed, Jun 24, 2020 at 12:23 PM Sven Van Asbroeck <thesven73@xxxxxxxxx> wrote:

> +       /*
> +        * On imx6 plus, enet_ref from ANATOP/CCM can be internally routed to
> +        * be the PTP clock source, instead of having to be routed through
> +        * pads.
> +        * Board designs which route the ANATOP/CCM clock through pads are
> +        * unaffected when routing happens internally. So on these designs,
> +        * route internally by default.
> +        */
> +       if (clksel == IMX6Q_GPR1_ENET_CLK_SEL_ANATOP &&
> +                       of_machine_is_compatible("fsl,imx6qp")) {
> +               if (!IS_ERR(gpr))

We could avoid checking for if (!IS_ERR(gpr)) two times in a row if
the following patch is applied before yours:
https://pastebin.com/raw/Ftkq2VVp

What do you think?

Thanks