Re: [PATCH v3] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

From: Sven Van Asbroeck
Date: Wed Jun 24 2020 - 14:24:30 EST


Hi Fabio,

On Wed, Jun 24, 2020 at 1:55 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> We could avoid checking for if (!IS_ERR(gpr)) two times in a row if
> the following patch is applied before yours:
> https://pastebin.com/raw/Ftkq2VVp
>
> What do you think?

I think this is a good idea.
I was never fully comfortable with checking IS_ERR(gpr) twice, but I
know from experience that minimal patches are more likely
to be accepted.

Shawn / Andy, what do you think? Should I re-spin this as a patch
set, with Fabio's patch in front?