Re: [PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA

[Robin Murphy]

On 2020-06-29 13:11, Geert Uytterhoeven wrote:
> If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config):
>
>      drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap':
>      dma-iommu.c:(.text+0x92e): undefined reference to `dma_pgprot'
>
> IOMMU_DMA must not be selected, unless HAS_DMA=y.

Wait, no, IOMMU_DMA should not be selected by drivers at all - it's for 
arch code to choose.

x86 just complicates matters with some of its arch code being in its 
IOMMU drivers...

Robin.

> Hence fix this by making SUN50I_IOMMU depend on HAS_DMA.
>
> Fixes: 4100b8c229b32835 ("iommu: Add Allwinner H6 IOMMU driver")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
>   drivers/iommu/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index 6dc49ed8377a5c12..b0f308cb7f7c2fc2 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -305,6 +305,7 @@ config ROCKCHIP_IOMMU
>   
>   config SUN50I_IOMMU
>   	bool "Allwinner H6 IOMMU Support"
> +	depends on HAS_DMA
>   	depends on ARCH_SUNXI || COMPILE_TEST
>   	select ARM_DMA_USE_IOMMU
>   	select IOMMU_API