Re: [PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA
From: Joerg Roedel
Date: Tue Jun 30 2020 - 06:09:54 EST
On Mon, Jun 29, 2020 at 05:29:36PM +0100, Robin Murphy wrote:
> On 2020-06-29 13:11, Geert Uytterhoeven wrote:
> > If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config):
> >
> > drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap':
> > dma-iommu.c:(.text+0x92e): undefined reference to `dma_pgprot'
> >
> > IOMMU_DMA must not be selected, unless HAS_DMA=y.
>
> Wait, no, IOMMU_DMA should not be selected by drivers at all - it's for arch
> code to choose.
Okay, but that is a different fix, right? I queued this patch for v5.8
for now.