Re: [RFC PATCH 1/2] Explicitly include linux/major.h where it is needed

From: Greg KH
Date: Tue Jun 30 2020 - 04:45:29 EST


On Tue, Jun 30, 2020 at 09:12:03AM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Wed, 17 Jun 2020 07:58:43 +0200 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Wed, Jun 17, 2020 at 09:27:47AM +1000, Stephen Rothwell wrote:
> > > This is in preparation for removing the include of major.h where it is
> > > not needed.
> > >
> > > These files were found using
> > >
> > > grep -E -L '[<"](uapi/)?linux/major\.h' $(git grep -l -w -f /tmp/xx)
> > >
> > > where /tmp/xx contains all the symbols defined in major.h. There were
> > > a couple of files in that list that did not need the include since the
> > > references are in comments.
> > >
> > > Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> >
> > Any reason this had an RFC, but patch 2/2 did not?
> >
> > They look good to me, I will be glad to take these, but do you still
> > want reviews from others for this? It seems simple enough to me...
>
> I am going to do another round of this patchset splitting out most of
> the "safe" removals that can be done anytime so other maintainers can
> take them. Then there will be the left over order dependent changes at
> the end.

Ok, I'll wait for the next round of patches, thanks.

greg k-h