RE: [Intel-wired-lan] [PATCH v1 3/5] ixgbe: use generic power management

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Vaibhav Gupta
> Sent: Monday, June 29, 2020 2:30 AM
> To: Bjorn Helgaas <helgaas@xxxxxxxxxx>; Bjorn Helgaas
> <bhelgaas@xxxxxxxxxx>; bjorn@xxxxxxxxxxx; Vaibhav Gupta
> <vaibhav.varodek@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>;
> Jakub Kicinski <kuba@xxxxxxxxxx>; Kirsher, Jeffrey T
> <jeffrey.t.kirsher@xxxxxxxxx>
> Cc: Vaibhav Gupta <vaibhavgupta40@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx;
> skhan@xxxxxxxxxxxxxxxxxxx; linux-kernel-
> mentees@xxxxxxxxxxxxxxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [PATCH v1 3/5] ixgbe: use generic power
> management
> 
> With legacy PM hooks, it was the responsibility of a driver to manage PCI
> states and also the device's power state. The generic approach is to let PCI
> core handle the work.
> 
> ixgbe_suspend() calls __ixgbe_shutdown() to perform intermediate tasks.
> __ixgbe_shutdown() modifies the value of "wake" (device should be
> wakeup enabled or not), responsible for controlling the flow of legacy PM.
> 
> Since, PCI core has no idea about the value of "wake", new code for generic
> PM may produce unexpected results. Thus, use
> "device_set_wakeup_enable()"
> to wakeup-enable the device accordingly.
> 
> Compile-tested only.
> 
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@xxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 61 +++++--------------
>  1 file changed, 15 insertions(+), 46 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@xxxxxxxxx>