RE: [Intel-wired-lan] [PATCH v1 4/5] ixgbevf: use generic power management

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Vaibhav Gupta
> Sent: Monday, June 29, 2020 2:30 AM
> To: Bjorn Helgaas <helgaas@xxxxxxxxxx>; Bjorn Helgaas
> <bhelgaas@xxxxxxxxxx>; bjorn@xxxxxxxxxxx; Vaibhav Gupta
> <vaibhav.varodek@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>;
> Jakub Kicinski <kuba@xxxxxxxxxx>; Kirsher, Jeffrey T
> <jeffrey.t.kirsher@xxxxxxxxx>
> Cc: Vaibhav Gupta <vaibhavgupta40@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx;
> skhan@xxxxxxxxxxxxxxxxxxx; linux-kernel-
> mentees@xxxxxxxxxxxxxxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [PATCH v1 4/5] ixgbevf: use generic power
> management
> 
> With legacy PM, drivers themselves were responsible for managing the
> device's power states and takes care of register states.
> 
> After upgrading to the generic structure, PCI core will take care of required
> tasks and drivers should do only device-specific operations.
> 
> The driver was invoking PCI helper functions like pci_save/restore_state(),
> and pci_enable/disable_device(), which is not recommended.
> 
> Compile-tested only.
> 
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@xxxxxxxxx>
> ---
>  .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 44 +++++--------------
>  1 file changed, 10 insertions(+), 34 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@xxxxxxxxx>