Re: [PATCH] kbuild: do not export LDFLAGS_vmlinux
From: Max Filippov
Date: Wed Jul 01 2020 - 16:14:32 EST
On Wed, Jul 1, 2020 at 12:30 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
[...]
> diff --git a/arch/xtensa/boot/boot-elf/Makefile b/arch/xtensa/boot/boot-elf/Makefile
> index 12ae1e91cb75..c6538d3321b9 100644
> --- a/arch/xtensa/boot/boot-elf/Makefile
> +++ b/arch/xtensa/boot/boot-elf/Makefile
> @@ -25,7 +25,7 @@ $(obj)/Image.o: vmlinux.bin $(OBJS)
> $(OBJS) $@
>
> $(obj)/../Image.elf: $(obj)/Image.o $(obj)/boot.lds
> - $(Q)$(LD) $(KBUILD_LDFLAGS) $(LDFLAGS_vmlinux) \
> + $(LD) $(KBUILD_LDFLAGS) \
Can that $(Q) be retained, please?
The rest LGTM.
> -T $(obj)/boot.lds \
> --build-id=none \
> -o $@ $(obj)/Image.o
--
Thanks.
-- Max