Re: [PATCH] kbuild: do not export LDFLAGS_vmlinux

[Masahiro Yamada]

On Thu, Jul 2, 2020 at 5:14 AM Max Filippov <jcmvbkbc@xxxxxxxxx> wrote:
>
> On Wed, Jul 1, 2020 at 12:30 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> [...]
>
> > diff --git a/arch/xtensa/boot/boot-elf/Makefile b/arch/xtensa/boot/boot-elf/Makefile
> > index 12ae1e91cb75..c6538d3321b9 100644
> > --- a/arch/xtensa/boot/boot-elf/Makefile
> > +++ b/arch/xtensa/boot/boot-elf/Makefile
> > @@ -25,7 +25,7 @@ $(obj)/Image.o: vmlinux.bin $(OBJS)
> >                 $(OBJS) $@
> >
> >  $(obj)/../Image.elf: $(obj)/Image.o $(obj)/boot.lds
> > -       $(Q)$(LD) $(KBUILD_LDFLAGS) $(LDFLAGS_vmlinux) \
> > +       $(LD) $(KBUILD_LDFLAGS) \
>
> Can that $(Q) be retained, please?
> The rest LGTM.


Oops, I temporarily deleted $(Q) for debugging,
then accidentally committed it.

I will restore $(Q) when this patch is applied.

Thanks.





> >                 -T $(obj)/boot.lds \
> >                 --build-id=none \
> >                 -o $@ $(obj)/Image.o
>
> --
> Thanks.
> -- Max



-- 
Best Regards
Masahiro Yamada