回复: [PATCH] usb: gadget: function: fix missing spinlock in f_uac1_legacy

From: Zhang, Qiang
Date: Mon Jul 06 2020 - 01:16:45 EST



________________________________________
发件人: linux-kernel-owner@xxxxxxxxxxxxxxx <linux-kernel-owner@xxxxxxxxxxxxxxx> 代表 qiang.zhang@xxxxxxxxxxxxx <qiang.zhang@xxxxxxxxxxxxx>
发送时间: 2020年7月5日 9:59
收件人: balbi@xxxxxxxxxx
抄送: gregkh@xxxxxxxxxxxxxxxxxxx; colin.king@xxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
主题: [PATCH] usb: gadget: function: fix missing spinlock in f_uac1_legacy

From: Zhang Qiang <qiang.zhang@xxxxxxxxxxxxx>

Signed-off-by: Zhang Qiang <qiang.zhang@xxxxxxxxxxxxx>
---
drivers/usb/gadget/function/f_uac1_legacy.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/usb/gadget/function/f_uac1_legacy.c b/drivers/usb/gadget/function/f_uac1_legacy.c
index 349deae7cabd..e2d7f69128a0 100644
--- a/drivers/usb/gadget/function/f_uac1_legacy.c
+++ b/drivers/usb/gadget/function/f_uac1_legacy.c
@@ -336,7 +336,9 @@ static int f_audio_out_ep_complete(struct usb_ep *ep, struct usb_request *req)

/* Copy buffer is full, add it to the play_queue */
if (audio_buf_size - copy_buf->actual < req->actual) {
+ spin_lock_irq(&audio->lock);
list_add_tail(&copy_buf->list, &audio->play_queue);
+ spin_unlock_irq(&audio->lock);
schedule_work(&audio->playback_work);
copy_buf = f_audio_buffer_alloc(audio_buf_size);
if (IS_ERR(copy_buf))
--
2.24.1