Re: [PATCH 03/11] ASoC: q6asm: make commands specific to streams

[Srinivas Kandagatla]

Thanks Pierre for quick review,

On 07/07/2020 17:52, Pierre-Louis Bossart wrote:
> > @@ -184,8 +186,8 @@ static void event_handler(uint32_t opcode, 
> > uint32_t token,
> > ÂÂÂÂÂ switch (opcode) {
> > ÂÂÂÂÂ case ASM_CLIENT_EVENT_CMD_RUN_DONE:
> > ÂÂÂÂÂÂÂÂÂ if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
> > -ÂÂÂÂÂÂÂÂÂÂÂ q6asm_write_async(prtd->audio_client,
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ prtd->pcm_count, 0, 0, NO_TIMESTAMP);
> > +ÂÂÂÂÂÂÂÂÂÂÂ q6asm_write_async(prtd->audio_client, prtd->stream_id,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ prtd->pcm_count, 0, 0, 0);
>
> sound/soc/qcom/qdsp6/q6asm.h:#define NO_TIMESTAMPÂÂÂ 0xFF00
>
> is the change on the previous line intentional?

May be not!

Plan is that the users of these apis will send flags directly instead of 
boiler plating this!

This change should go as part of next patch("[PATCH 04/11] ASoC: q6asm: 
use flags directly from asm-dai") which would make it much clear!

thanks,
srini