Re: [PATCH 06/11] ASoC: q6asm: add support to remove intial and trailing silence

[Srinivas Kandagatla]

Thanks Pierre for review,

On 07/07/2020 17:55, Pierre-Louis Bossart wrote:
> > +int q6asm_stream_remove_initial_silence(struct audio_client *ac,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ uint32_t stream_id,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ uint32_t initial_samples)
> > +{
> > +ÂÂÂ return q6asm_stream_remove_silence(ac, stream_id,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ ASM_DATA_CMD_REMOVE_INITIAL_SILENCE,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ initial_samples);
> > +}
> > +EXPORT_SYMBOL_GPL(q6asm_stream_remove_initial_silence);
> > +
> > +int q6asm_stream_remove_trailing_silence(struct audio_client *ac, 
> > uint32_t stream_id,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ uint32_t trailing_samples)
> > +{
> > +ÂÂÂ return q6asm_stream_remove_silence(ac, stream_id,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ ASM_DATA_CMD_REMOVE_TRAILING_SILENCE,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ trailing_samples);
> > +}
> > +EXPORT_SYMBOL_GPL(q6asm_stream_remove_trailing_silence);
>
> do you need those wrappers? Might as well call the _remove_silence() 
> function with the right parameters, no?

Intention is to abstract out the CMDs within dsp specific wrappers.
This is how rest of the apis are also done! Also its possible that in 
future these IDs could potentially upgraded on different versions of DSP fw.
Making a single call would mean that either CMD IDs or some kinda of 
other intermediate flags.

So I would like to keep it as it is for now!

Thanks,
srini