Re: [PATCH] scsi: virtio_scsi: Remove unnecessary condition checks

From: Paolo Bonzini
Date: Thu Jul 09 2020 - 13:25:55 EST


On 09/07/20 19:16, Markus Elfring wrote:
>> + mempool_destroy(virtscsi_cmd_pool);
>> + virtscsi_cmd_pool = NULL;
>> + kmem_cache_destroy(virtscsi_cmd_cache);
>> + virtscsi_cmd_cache = NULL;
>> return ret;
>> }
>
> How do you think about to add a jump target so that the execution
> of a few statements can be avoided according to a previous
> null pointer check?

The point of the patch is precisely to simplify the code, executing a
couple more instruction is not an issue.

Paolo