Re: [PATCH] scsi: virtio_scsi: Remove unnecessary condition checks
From: Markus Elfring
Date: Thu Jul 09 2020 - 16:56:14 EST
>>> + mempool_destroy(virtscsi_cmd_pool);
>>> + virtscsi_cmd_pool = NULL;
>>> + kmem_cache_destroy(virtscsi_cmd_cache);
>>> + virtscsi_cmd_cache = NULL;
>>> return ret;
>>> }
>>
>> How do you think about to add a jump target so that the execution
>> of a few statements can be avoided according to a previous
>> null pointer check?
>
> The point of the patch is precisely to simplify the code,
I propose another bit of fine-tuning there.
> executing a couple more instruction is not an issue.
Can an additional label help here besides a possible identifier renaming?
Regards,
Markus