Re: [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip

From: Andy Shevchenko
Date: Thu Jul 09 2020 - 16:51:19 EST


On Thu, Jul 9, 2020 at 11:16 PM Eddie James <eajames@xxxxxxxxxxxxx> wrote:
>
> IBM created an implementation of the PCA9552 on a PIC16F
> microcontroller. The I2C device addresses are different from the
> hardware PCA9552, so add a new compatible string and associated
> platform data to be able to probe this device.

This is weird. I would rather expect ibm prefix with corresponding part number.

> + pca9552_ibm,

> + [pca9552_ibm] = {

> + { "pca9552-ibm", pca9552_ibm },

> + { .compatible = "nxp,pca9552-ibm", .data = (void *)pca9552_ibm },


--
With Best Regards,
Andy Shevchenko