Re: [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip

[Eddie James]

On 7/9/20 3:50 PM, Andy Shevchenko wrote:
> On Thu, Jul 9, 2020 at 11:16 PM Eddie James <eajames@xxxxxxxxxxxxx> wrote:
> > IBM created an implementation of the PCA9552 on a PIC16F
> > microcontroller. The I2C device addresses are different from the
> > hardware PCA9552, so add a new compatible string and associated
> > platform data to be able to probe this device.
> This is weird. I would rather expect ibm prefix with corresponding part number.


Yep I agree now, see my note to Pavel just now.


Thanks,

Eddie


> > +       pca9552_ibm,
> > +       [pca9552_ibm] = {
> > +       { "pca9552-ibm", pca9552_ibm },
> > +       { .compatible = "nxp,pca9552-ibm", .data = (void *)pca9552_ibm },