Re: [PATCH 22/25] pinctrl: tegra: pinctrl-tegra194: Do not initialise field twice

[Thierry Reding]

On Mon, Jul 13, 2020 at 03:49:27PM +0100, Lee Jones wrote:
> Both PIN_PINGROUP_ENTRY_Y() and DRV_PINGROUP_ENTRY_Y() macros are
> called for each of the 2 pin groups defined here, and both of them
> initialise 'drv_reg', causing the compiler to complain.
> 
> Only initialise 'drv_reg' once.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: warning: initialized field overwritten [-Woverride-init]
>  71 | .drv_reg = ((r)), | ^
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:105:2: note: in expansion of macro âDRV_PINGROUP_ENTRY_Yâ
>  105 | DRV_PINGROUP_ENTRY_Y(0x14004, 12, 5, 20, 5, -1, -1, -1, -1, 0)
>  | ^~~~~~~~~~~~~~~~~~~~
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro âdrive_pex_l5_clkreq_n_pgg0â
>  124 | drive_##pg_name, | ^~~~~~
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:128:2: note: in expansion of macro âPINGROUPâ
>  128 | PINGROUP(pex_l5_clkreq_n_pgg0, PE5, RSVD1, RSVD2, RSVD3, 0x14000, 0,
>  | ^~~~~~~~
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: note: (near initialization for âtegra194_groups[0].drv_regâ)
>  71 | .drv_reg = ((r)), | ^
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:105:2: note: in expansion of macro âDRV_PINGROUP_ENTRY_Yâ
>  105 | DRV_PINGROUP_ENTRY_Y(0x14004, 12, 5, 20, 5, -1, -1, -1, -1, 0)
>  | ^~~~~~~~~~~~~~~~~~~~
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro âdrive_pex_l5_clkreq_n_pgg0â
>  124 | drive_##pg_name, | ^~~~~~
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:128:2: note: in expansion of macro âPINGROUPâ
>  128 | PINGROUP(pex_l5_clkreq_n_pgg0, PE5, RSVD1, RSVD2, RSVD3, 0x14000, 0,
>  | ^~~~~~~~
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: warning: initialized field overwritten [-Woverride-init]
>  71 | .drv_reg = ((r)), | ^
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:107:2: note: in expansion of macro âDRV_PINGROUP_ENTRY_Yâ
>  107 | DRV_PINGROUP_ENTRY_Y(0x1400c, 12, 5, 20, 5, -1, -1, -1, -1, 0)
>  | ^~~~~~~~~~~~~~~~~~~~
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro âdrive_pex_l5_rst_n_pgg1â
>  124 | drive_##pg_name, | ^~~~~~
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:130:2: note: in expansion of macro âPINGROUPâ
>  130 | PINGROUP(pex_l5_rst_n_pgg1, PE5, RSVD1, RSVD2, RSVD3, 0x14008, 0,
>  | ^~~~~~~~
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: note: (near initialization for âtegra194_groups[1].drv_regâ)
>  71 | .drv_reg = ((r)), | ^
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:107:2: note: in expansion of macro âDRV_PINGROUP_ENTRY_Yâ
>  107 | DRV_PINGROUP_ENTRY_Y(0x1400c, 12, 5, 20, 5, -1, -1, -1, -1, 0)
>  | ^~~~~~~~~~~~~~~~~~~~
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro âdrive_pex_l5_rst_n_pgg1â
>  124 | drive_##pg_name, | ^~~~~~
>  drivers/pinctrl/tegra/pinctrl-tegra194.c:130:2: note: in expansion of macro âPINGROUPâ
>  130 | PINGROUP(pex_l5_rst_n_pgg1, PE5, RSVD1, RSVD2, RSVD3, 0x14008, 0,
>  | ^~~~~~~~
> 
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Jonathan Hunter <jonathanh@xxxxxxxxxx>
> Cc: linux-tegra@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
>  drivers/pinctrl/tegra/pinctrl-tegra194.c | 1 -
>  1 file changed, 1 deletion(-)

Indeed, looks correct to me:

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature