Re: [PATCH v4 19/24] raid5: Use sequence counter with associated spinlock

From: Song Liu
Date: Wed Jul 22 2020 - 02:40:31 EST


On Mon, Jul 20, 2020 at 8:57 AM Ahmed S. Darwish
<a.darwish@xxxxxxxxxxxxx> wrote:
>
> A sequence counter write side critical section must be protected by some
> form of locking to serialize writers. A plain seqcount_t does not
> contain the information of which lock must be held when entering a write
> side critical section.
>
> Use the new seqcount_spinlock_t data type, which allows to associate a
> spinlock with the sequence counter. This enables lockdep to verify that
> the spinlock used for writer serialization is held when the write side
> critical section is entered.
>
> If lockdep is disabled this lock association is compiled out and has
> neither storage size nor runtime overhead.
>
> Signed-off-by: Ahmed S. Darwish <a.darwish@xxxxxxxxxxxxx>

Acked-by: Song Liu <song@xxxxxxxxxx>