Re: [PATCH v6 2/5] scsi: ufs: Add UFS-feature layer

From: Christoph Hellwig
Date: Wed Jul 22 2020 - 02:41:35 EST


On Mon, Jul 13, 2020 at 07:40:40PM +0900, Daejun Park wrote:
> This patch is adding UFS feature layer to UFS core driver.
>
> UFS Driver data structure (struct ufs_hba)

Independent of the problems with the concept of HPB, this patch is
just really bad software architecture. Don't just add random
indirection layers that do represent an actual real abstraction.
As-is it is just another crap hook layer without a proper absteaction.

Nacked^2-by: Christoph Hellwig <hch@xxxxxx>