Re: Re: [PATCH] ALSA: pci/asihpi: Fix memory leak in snd_card_asihpi_capture_open()

From: dinghao . liu
Date: Thu Aug 13 2020 - 02:40:05 EST


> On Mon, 10 Aug 2020 08:39:55 +0200,
> Dinghao Liu wrote:
> >
> > When snd_pcm_hw_constraint_pow2() fails, dpcm should be freed
> > just like when hpi_instream_open() fails.
>
> It will be cleaned up via runtime->private_free call in the caller
> side (snd_pcm_open -> snd_pcm_release_substream ->
> snd_pcm_detach_substream), hence this would result in double-free.
>

It's clear to me, thanks!

Regards,
Dinghao