Re: Re: [PATCH] ALSA: echoaudio: Fix memory leak in snd_echo_resume()

[dinghao . liu]

> On Mon, 10 Aug 2020 08:14:58 +0200,
> Dinghao Liu wrote:
> > 
> > When restore_dsp_rettings() fails, chip should be freed
> > just like when init_hw() and request_irq() fails.
> > 
> > Fixes: 47b5d028fdce8 ("ALSA: Echoaudio - Add suspend support #2")
> > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
> 
> Actually it's rather wrong to call snd_echo_free() in the resume error
> path.  This may lead to an Oops at the next time the system goes to
> resume.  That said, we should drop snd_echo_free() calls in other
> error paths in snd_echo_resume() instead.
> 

Thank you for your advice! I will send a new patch to fix this soon.

Regards,
Dinghao