Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support
From: Heikki Krogerus
Date: Tue Aug 25 2020 - 04:19:41 EST
On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote:
> Hi Andy,
>
> On 19/8/2020 3:55 pm, Andy Shevchenko wrote:
> > On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX
> > <vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx> wrote:
> > > On 18/8/2020 4:40 pm, Andy Shevchenko wrote:
> > > > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> > > > > USB external connector chip PTN5150 used on the Intel LGM SoC
> > > > > boards to detect the USB type and connection.
> > > > Internally I meant you can send cleanups, but couple of patches here are the
> > > > features and were still under discussion... But here we are.
> > >
> > > you mean asking us to implement the Heikki suggested as below..
> > >
> > > Heikki Krogerus: register the port and the partner attached to it with
> > > the USB Type-C connector class in the driver. Is my understaanding
> > > right? if not, please explain it. Thanks!
> >
> > When you mention somebody, don't forget to Cc them (now done by me).
> Sure, Thank you
So the patches 1-5 are fine. The rest needs to be rewritten.
thanks,
--
heikki