Re: [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to HW register

[Felipe Balbi]

Hi,

Paul Cercueil <paul@xxxxxxxxxxxxxxx> writes:
>>>>>   @@ -246,9 +241,8 @@ static void x1830_usb_phy_init(struct usb_phy
>>>>>  *phy)
>>>>>    		USBPCR1_DMPD | USBPCR1_DPPD;
>>>>>    	writel(reg, priv->base + REG_USBPCR1_OFFSET);
>>>>> 
>>>>>   -	reg = USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT
>>>>>  |	USBPCR_TXPREEMPHTUNE |
>>>>>   +	return USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT |
>>>>>  USBPCR_TXPREEMPHTUNE |
>>>>>    		USBPCR_COMMONONN | USBPCR_POR;
>>>>>   -	writel(reg, priv->base + REG_USBPCR_OFFSET);
>>>> 
>>>>  not a bug fix
>>> 
>>>  Well, if you don't like my bug fix, next time wait for my 
>>> Reviewed-by.
>> 
>> why so angry? Take a break every once in a while. Besides, someone 
>> else
>> already sent the oneliner before you ;-)
>
> I'm just pissed that this patch has not been tested. I don't like 
> sloppy work.

yeah, s**t happens

>> In any case, why should I wait for your Reviewed-by? Get maintainer
>> doesn't list you as the maintainer for it. Do you want to update
>> MAINTAINERS by any chance?
>
> Yes, I thought I was (I'm maintainer of all Ingenic drivers), that also 
> explains why I wasn't Cc'd for the oneliner patch you mentioned...
>
> IIRC Zhou has a patch to move the driver to drivers/phy/, I'll add 
> myself as maintainer once it's moved there.

makes sense

-- 
balbi

Attachment: signature.asc
Description: PGP signature